On 2018-12-06 21:06, Paolo Bonzini wrote: > On 06/12/18 17:15, Thomas Huth wrote: >>> >>> - for (j = 0; j < 256; j++) { >>> - uint32_t a = readl(s->memory.regions[i].guest_phys_addr + j*4); >>> + for (j = 0; j < 1024; j++) { >>> + uint32_t a = readb(s->memory.regions[i].guest_phys_addr + j); >> Can't you simply use memread() intead? > > Yes, I guess I could do memread + memcmp, but I wanted to change the > code as little as possible here.
OK, fair. Reviewed-by: Thomas Huth <th...@redhat.com>