On 12/5/18 10:38 AM, Vladimir Sementsov-Ogievskiy wrote:
- magic = ldq_be_p(buf);
+ magic = be64_to_cpu(magic);
Isn't it better to use be64_to_cpus?
No. We're intentionally getting rid of that because of clang; see commit
80c7c2b0.
Ok, thanks. In this case it should be safe, but if we decided to avoid these
functions in general than OK.
Hmm, not in general, but only in nbd.. Strange, why not in qcow2 for ex?,
Peter is working on that - it's a slow process, because he's sending
separate patch series per maintainer, so they are not all getting
checked in at the same time. But the idea is that once everything is
converted, we nuke the *_to_*s variants as unused, and in the meantime,
we don't add more uses of it.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
