Auger Eric <eric.au...@redhat.com> writes: > Hi Markus, > > On 12/5/18 3:16 PM, Markus Armbruster wrote: >> Auger Eric <eric.au...@redhat.com> writes: [...] >>> nit: g_assert_not_reached() here and below. >> >> In my opinion, g_assert_not_reached() & friends are an overly ornate >> reinvention of an old and perfectly adequate wheel. >> >> A long time ago for reasons since forgotten, the maintainers in charge >> back then demanded abort() instead of assert(0). Either is fine with >> me. >> >> I tolerate g_assert_not_reached() in files that already use g_assert(). >> This one doesn't. >> >> In any case, I'd drop the comment. > > OK I did not know. In the past I was encouraged to use it.
Some maintainers like ornate ;) > Thanks > > Eric >> >> Note that I'm not this file's maintainer. >> >> [...]
