On 12/4/18 7:29 AM, Peter Maydell wrote: > In sdhci_sysbus_realize() we override the initialization of > s->iomem that sdhci_common_realize() performs. However we > don't destroy the old memory region before reinitializing > it, which means that the memory allocated for mr->name in > memory_region_do_init() is leaked. > > Since sdhci_initfn() already initializes s->io_ops to > &sdhci_mmio_ops, always use that in sdhci_common_realize() > and remove the now-unnecessary reinitialization of the > MMIO region from sdhci_sysbus_realize(). > > Spotted by clang's leak sanitizer. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > hw/sd/sdhci.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
