On Nov 30 16:14, Peter Maydell wrote: > On Tue, 20 Nov 2018 at 21:26, Aaron Lindsay > <aa...@os.amperecomputing.com> wrote: > > diff --git a/target/arm/cpu.h b/target/arm/cpu.h > > index 50de58e4a2..32c3397948 100644 > > --- a/target/arm/cpu.h > > +++ b/target/arm/cpu.h > > @@ -993,6 +993,16 @@ void pmu_op_finish(CPUARMState *env); > > void pmu_pre_el_change(ARMCPU *cpu, void *ignored); > > void pmu_post_el_change(ARMCPU *cpu, void *ignored); > > > > +/* > > + * get_pmceid > > + * @env: CPUARMState > > + * > > + * Return the PMCEID[01]_EL0 register values corresponding to the counters > > + * which are supported given the current configuration (`which` is 0 or 1 > > to > > + * indicate which PMCEID should be returned) > > + */ > > Nit: you should have a line here below the one for "@env" > for the "@which" parameter, and the reference to it in > the text should just be "@which", not "`which`" (or just > put that description in the line saying what @which is > rather than having it in a parenthetical).
Thanks, I've fixed this for v9. -Aaron
