On Fri, 30 Nov 2018 at 11:29, Gerd Hoffmann <kra...@redhat.com> wrote: > > On Thu, Nov 29, 2018 at 08:09:56AM -0600, Eric Blake wrote: > > On 11/29/18 6:35 AM, Gerd Hoffmann wrote: > > > We must set the correct context (via eglMakeCurrent) before > > > calling qemu_egl_create_context, so we need a thin wrapper and can't > > > hook qemu_egl_create_context directly as ->dpy_gl_ctx_create callback. > > > > > > Reported-by: Frederik Carlier <frederik.carl...@quamotion.mobi> > > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > > > --- > > > ui/egl-headless.c | 10 +++++++++- > > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > How severe is this? Is it something that would warrant 3.1-rc4, or are we > > safe deferring it to 4.0? > > Fixes segfaults (should probably update the commit message to say so), > therefore 3.1 material IMHO.
Original reporter seems to be saying in the bug report that this doesn't actually fix his bug ? Is this a regression from 3.0? It doesn't look like it from a quick look at the git history, so given that plus the uncertainty about whether it's actually fixing the bug I'm inclined to defer this to 4.0. thanks -- PMM
