Marc-André Lureau <[email protected]> writes: > Hi > > On Mon, Dec 3, 2018 at 11:26 AM Markus Armbruster <[email protected]> wrote: >> >> Marc-André Lureau <[email protected]> writes: >> >> > Chardev backends may not handle safely IO events from concurrent >> > threads. >> >> What exactly could go wrong? Or is this a well-known fact that doesn't >> need further elaboration? > > chardev are not thread-safe. Only the write path is, since commit > 9005b2a7589540a3733b3abdcfbccfe7746cd1a1.
Add this to your commit message? Your call. >> "safely handle I/O events" >> >> > Better to wake up the chardev from the monitor IO thread if >> > it's being used as the chardev context. >> > >> > Unify code paths by using a BH in all cases. >> > >> > Drop the now redundant aio_notify() call. >> > >> > Signed-off-by: Marc-André Lureau <[email protected]> [...]
