On 03/08/11 18:46, Anthony Liguori wrote: > On 03/08/2011 10:44 AM, Jes Sorensen wrote: >> On 03/08/11 14:42, Anthony Liguori wrote: >> It kinda sorta covers it. The problem with that is that you then have to >> do a string match of the return values to determine which of the cases >> happened, which isn't very nice. But I guess we can do that for now. > > Right, but this can be done in the HMP command such that the HMP command > still prints out the warning message. > > The key is to have well documented error semantics where the various > cases can be distinguished because then we can ensure that we can not > only print out a nice error message in HMP, but that a remote QMP client > (like libvirt) can also generate a high quality error message.
Have a look at v4 then, I've changed it to report errors back according to this. Jes
