On Thu, 29 Nov 2018 10:02:24 -0500
Tony Krowiak <akrow...@linux.ibm.com> wrote:
> On 11/29/18 6:45 AM, Cornelia Huck wrote:
> > On Thu, 22 Nov 2018 17:35:51 +0100
> > Pierre Morel <pmo...@linux.ibm.com> wrote:
> >> diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
> >> index 65de952..94e5a1a 100644
> >> --- a/hw/vfio/ap.c
> >> +++ b/hw/vfio/ap.c
> >> @@ -35,9 +35,6 @@ typedef struct VFIOAPDevice {
> >> VFIODevice vdev;
> >> } VFIOAPDevice;
> >>
> >> -#define VFIO_AP_DEVICE(obj) \
> >> - OBJECT_CHECK(VFIOAPDevice, (obj), VFIO_AP_DEVICE_TYPE)
> >
> > Hm?
>
> I received a comment from Thomas Huth in Message ID
> <2291104a-4cbf-e4fd-3496-fa0910beb...@redhat.com>
> that DO_UPCAST should be avoided in new code. This macro
> should probably be restored and an AP_DEVICE() macro added.
Yes, that makes sense.
