On 29/11/18 10:01, Paolo Bonzini wrote: > Pull the test before the anticipated exits from the process sub. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > scripts/checkpatch.pl | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index d58fcb1efd..c216c55e01 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2866,6 +2866,10 @@ sub process { > } > } > > + if ($is_patch && $chk_signoff && $signoff == 0) { > + ERROR("Missing Signed-off-by: line(s)\n"); > + } > + > # If we have no input at all, then there is nothing to report on > # so just keep quiet. > if ($#rawlines == -1) { > @@ -2887,9 +2891,6 @@ sub process { > if (!$is_patch) { > ERROR("Does not appear to be a unified-diff format patch\n"); > } > - if ($is_patch && $chk_signoff && $signoff == 0) { > - ERROR("Missing Signed-off-by: line(s)\n"); > - } > > print report_dump(); > if ($summary && !($clean == 1 && $quiet == 1)) { >