On 26/11/2018 20:59, Juan Quintela wrote: > Signed-off-by: Juan Quintela <quint...@redhat.com> > > --- > > Remove the "contributions after" clause. This is based on > > commit 59ccd20a9ac719cff82180429458728f03ec612f > Author: KONRAD Frederic <fred.kon...@greensocs.com> > Date: Wed Apr 24 10:07:56 2013 +0200 > --- > hw/virtio/Makefile.objs | 1 + > hw/virtio/virtio-pci.c | 52 ----------------------- > hw/virtio/virtio-pci.h | 14 ------- > hw/virtio/virtio-rng-pci.c | 86 ++++++++++++++++++++++++++++++++++++++ > tests/Makefile.include | 1 + > 5 files changed, 88 insertions(+), 66 deletions(-) > create mode 100644 hw/virtio/virtio-rng-pci.c ... > diff --git a/tests/Makefile.include b/tests/Makefile.include > index fb0b449c02..e8235890ec 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -149,6 +149,7 @@ check-qtest-virtio-y += tests/virtio-net-test$(EXESUF) > check-qtest-virtio-y += tests/virtio-balloon-test$(EXESUF) > check-qtest-virtio-y += tests/virtio-blk-test$(EXESUF) > check-qtest-virtio-y += tests/virtio-rng-test$(EXESUF) > +check-qtest-virtio-$(CONFIG_VIRTIO_RNG) += tests/virtio-rng-test$(EXESUF)
I think you should remove the line just above. except that: Reviewed-by: Laurent Vivier <lviv...@redhat.com>