Hi Gerd, On 22/11/18 14:32, Gerd Hoffmann wrote: > Guest writes to a readonly register trigger the assert in > intel_hda_reg_write(). Add a check and just ignore them.
Is this 3.1 material? It seems to apply. > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1628433 > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > hw/audio/intel-hda.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c > index 23a2cf6484..066532713c 100644 > --- a/hw/audio/intel-hda.c > +++ b/hw/audio/intel-hda.c > @@ -929,6 +929,10 @@ static void intel_hda_reg_write(IntelHDAState *d, const > IntelHDAReg *reg, uint32 > if (!reg) { > return; > } > + if (!reg->wmask) { > + /* read-only register */ Can you add: qemu_log_mask(LOG_GUEST_ERROR, "intel-hda: Register %s is read-only\n", reg->name); Regardless: Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > + return; > + } > > if (d->debug) { > time_t now = time(NULL); >
