On 2018-11-20 21:23, Philippe Mathieu-Daudé wrote: > On 20/11/18 18:42, Thomas Huth wrote: >> I apparently missed some more files and even a complete machine (the >> "imx25-pdk") in my previous patch... but now we should hopefully have >> a completely coverage for all available ARM boards. >> >> Fixes: 95a5db3ae5698b49c63144610ad02913e780c828 >> Signed-off-by: Thomas Huth <th...@redhat.com> >> --- >> v2: Dropped smmu* files from this patch >> >> MAINTAINERS | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 1032406..36ffc01 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -533,6 +533,18 @@ L: qemu-...@nongnu.org >> S: Odd Fixes >> F: hw/arm/gumstix.c >> +i.MX25 PDK >> +M: Peter Maydell <peter.mayd...@linaro.org> >> +R: Jean-Christophe Dubois <j...@tribudubois.net> >> +L: qemu-...@nongnu.org >> +S: Odd Fixes >> +F: hw/arm/fsl-imx25.c >> +F: hw/arm/imx25_pdk.c >> +F: hw/misc/imx25_ccm.c >> +F: include/hw/arm/fsl-imx25.h >> +F: include/hw/misc/imx25_ccm.h > >> +F: tests/ds1338-test.c > > This last entry is weird alone (at least without the hw/timer/ds1338.c > device listed). > > This RTC is also used by the aspeed/realview/versatilepb boards.
You're right. I've added it since the test uses "-machine imx25-pdk", but the correct way is likely to add a separate section for the timer device instead. I'll remove this line in v3. >> + >> i.MX31 (kzm) >> M: Peter Chubb <peter.ch...@nicta.com.au> >> M: Peter Maydell <peter.mayd...@linaro.org> >> @@ -615,6 +627,7 @@ R: Andrew Baumann <andrew.baum...@microsoft.com> >> R: Philippe Mathieu-Daudé <f4...@amsat.org> >> L: qemu-...@nongnu.org >> S: Odd Fixes >> +F: hw/arm/raspi.c >> F: hw/arm/raspi_platform.h >> F: hw/*/bcm283* >> F: include/hw/arm/raspi* >> @@ -641,6 +654,7 @@ F: hw/arm/z2.c >> F: hw/*/pxa2xx* >> F: hw/misc/mst_fpga.c >> F: include/hw/arm/pxa.h >> +F: include/hw/arm/sharpsl.h > > I think hw/gpio/zaurus.c goes there too. Well spotted. I'll add it in v3. And I think we should add hw/display/tc6393xb.c here as well. Thomas