On 20/11/18 13:57, Igor Mammedov wrote: > On Mon, 19 Nov 2018 18:14:26 +0100 > Paolo Bonzini <pbonz...@redhat.com> wrote: > >> On 19/11/18 16:31, Igor Mammedov wrote: >>> I've tried to give suggestions how to restructure series >>> on per patch basis. In my opinion it quite possible to split >>> series in several smaller ones and it should really help with >>> making series cleaner and easier/faster to review/amend/merge >>> vs what we have in v5. >> >> This is true, on the other hand the series makes sense together and, >> even if the patches are more or less independent, they also all follow >> the same "plan". For reviewing v6, are you aware of Patchew's series >> diff functionality? It can tell you which patches had comments in v5, >> reorder patches if applicable, and display deleted and new patches at >> the right point in the series. > Thanks, I'll give it a try. > > Suggestion to split series mostly comes from contributor's point of view, > it much easier to amend small series than a larger one.
That's true, on the other hand rules exist to have exceptions. :) IIRC your AML builder patch was also a huge series, this is not very different. Paolo
