On 10/24/18 4:40 AM, Mao Zhongyi wrote:
Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using
$() everywhere.
Cc: kw...@redhat.com
Cc: mre...@redhat.com
Cc: ebl...@redhat.com
Suggested-by: Eric Blake <ebl...@redhat.com>
Signed-off-by: Mao Zhongyi <maozhon...@cmss.chinamobile.com>
---
tests/qemu-iotests/check | 60 ++++++++++++++++----------------
tests/qemu-iotests/common.config | 4 +--
2 files changed, 32 insertions(+), 32 deletions(-)
Only affects tests/ so safe for 3.1. I'm happy to take this through my
NBD queue, since Dan's test addition will also be impacted by this change.
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index b37713277d..89ed275988 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -590,7 +590,7 @@ fi
export QEMU_NBD_PROG="$(type -p "$QEMU_NBD_PROG")"
if [ -z "$QEMU_VXHS_PROG" ]; then
- export QEMU_VXHS_PROG="`set_prog_path qnio_server`"
+ export QEMU_VXHS_PROG="$(set_prog_path qnio_server)"
fi
Interesting indentation change while at it. But 4 spaces does seem to
be more consistent.
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
