Hi Jean, Bharat, On 11/14/18 5:41 PM, Auger Eric wrote: > Hi Jean, > > On 11/14/18 5:01 PM, Jean-Philippe Brucker wrote: >> On 09/11/2018 11:29, Eric Auger wrote: >>> +static void create_virtio_iommu(VirtMachineState *vms, >>> + const char *pciehb_nodename, PCIBus *bus) >>> +{ >>> + const char compat[] = "virtio,pci-iommu"; >>> + uint16_t bdf = 0x8; /* 00:01.0 */ >>> + DeviceState *dev; >>> + char *node; >>> + >>> + dev = qdev_create(BUS(bus), TYPE_VIRTIO_IOMMU_PCI); >>> + object_property_set_bool(OBJECT(dev), true, "realized", &error_fatal); >> >> For the Arm virt platform, should msi_bypass default to false? Otherwise >> I don't think pass-through to guest userpace will work. > That's correct. It's a regression compared to v7. I will fix this soon > while doing the pc machine integration + resv regions flaws you reported > in the meantime.
The reported issues related to probe requests are fixed in the following branch: https://github.com/eauger/qemu/tree/v3.1.0-rc1-virtio-iommu-v0.8.1 This branch was used to test [PATCH v4 0/7] Add virtio-iommu driver Thanks Eric > > Thanks! > > Eric >> >> Thanks, >> Jean >> >