-----Original Message----- From: Eric Blake [mailto:ebl...@redhat.com] Sent: 2018年11月16日 6:03 To: xiezhide <xiezh...@huawei.com>; qemu-devel@nongnu.org Cc: be...@igalia.com; arm...@redhat.com; zengcanfu 00215970 <zengca...@huawei.com>; gr...@kaod.org; aneesh.ku...@linux.vnet.ibm.com; Jinxuefeng <jinxuef...@huawei.com>; Chenhui (Felix, Euler) <chenhui.r...@huawei.com> Subject: Re: [Qemu-devel] [PATCH v4 2/4] fsdev-throttle-qmp: move struct ThrottleLimits to new file
On 11/15/18 3:41 PM, Eric Blake wrote: > On 11/15/18 2:55 AM, xiezhide wrote: >> this patch move ThrottleLimits to new file and rename struct field >> with common format > > As written, you need s/move/moves/ and s/rename/renames/ to match the > singular actor 'this patch'. Or, if you stick with my preference for > imperative sense, s/this patch move/Move/ > > s/to new/to a new/ > >> >> Signed-off-by: xiezhide <xiezh...@huawei.com> >> --- > >> +++ b/Makefile >> @@ -106,6 +106,7 @@ GENERATED_FILES += qapi/qapi-types-sockets.h >> qapi/qapi-types-sockets.c >> GENERATED_FILES += qapi/qapi-types-tpm.h qapi/qapi-types-tpm.c >> GENERATED_FILES += qapi/qapi-types-trace.h qapi/qapi-types-trace.c >> GENERATED_FILES += qapi/qapi-types-transaction.h >> qapi/qapi-types-transaction.c >> +GENERATED_FILES += qapi/qapi-types-tlimits.h >> +qapi/qapi-types-tlimits.c > > tlimits comes before tpm, not after transaction. (Multiple times in > this file) Or, just apply your patch after mine[1], for a much simpler task of inserting 'tlimits' in the right place within QAPI_MODULES. [1] https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg03070.html Great, it makes the task very simple. thanks Thanks Kidd
