On Wed, Nov 14, 2018 at 14:41:53 +0000, Alex Bennée wrote:
> Emilio G. Cota <c...@braap.org> writes:
(snip)
> > -static GHashTable *helper_table;
> > +static struct qht helper_table;
> > +static bool helper_table_inited;
>
> Having a flag for initialisation seems a little excessive considering
> we've moved that initialisation into tcg_context_init() which has to be
> called before we do anything TCG related.
(snip)
> > + helper_table_inited = true;
>
> so I think we can drop this and...
(snip)
> > +static inline const char *tcg_helper_find(TCGContext *s, uintptr_t val)
> > {
> > const char *ret = NULL;
> > - if (helper_table) {
> > - TCGHelperInfo *info = g_hash_table_lookup(helper_table,
> > (gpointer)val);
> > + if (helper_table_inited) {
>
> change this to a assert(helper_table.cmp) if you really want to.
I like this suggestion. The only caller of tcg_helper_find
is tcg_dump_ops, which is unlikely to be called on an
uninitialized TCGContext.
I have added this to v2, without the assert.
(snip)
> Otherwise:
>
> Reviewed-by: Alex Bennée <alex.ben...@linaro.org>
Thanks!
E.
