On Sat, Mar 5, 2011 at 6:56 AM, Michael Tokarev <m...@tls.msk.ru> wrote: > 05.03.2011 00:08, Corentin Chary wrote: >> On Fri, Mar 4, 2011 at 12:46 PM, Michael Tokarev <m...@tls.msk.ru> wrote: > [] >>> The attached slightly different patch fixes both places and fixes >>> them for good (hopefully anyway). Runtime-tested for the tight >>> case, but honestly, I didn't wait for 2G of output ;) >>> >> Could you re-send it inline (not as an attachment), and CC Anthony ? > > What's wrong with using an attachment? The whole email can be > fed into patch(1) (or git-am, whatever) and either will do the > job. But here it goes, anyway, with one possible caveat - I'm > not sure anymore it will apply, since now I used cut-n-paste.
It's easier for reviewer because it allow people to view and comment the code directly in a mail client. The prefered way to send patch is `git format-patch` and `git send-email`. If you use these two tools, you can be sure that all will be ok :).
