On 7 November 2018 at 20:21, Eric Blake <ebl...@redhat.com> wrote: > On 11/6/18 3:45 AM, Paolo Bonzini wrote: >> >> On 06/11/2018 00:16, Eric Blake wrote: >>> >>> On 10/18/18 3:31 PM, Paolo Bonzini wrote: >>>> >>>> From: Artem Pisarenko <artem.k.pisare...@gmail.com> >>>> >>>> Attributes are simple flags, associated with individual timers for their >>>> whole lifetime. They intended to be used to mark individual timers for >>>> special handling when they fire. > > >>> git bisect points to this patch as the reason that 'make check' is >>> failing for me with: >> >> >> I think you have a stale file somewhere, because "git grep timer_init_tl >> 89a603a0c80ae3d6a8711571550b2ae9a01ea909" shows no occurrences. > > > Indeed a stale file, as 'find -name "*.o' -delete' cleared up the issue - > but it means we have a missing makefile dependency such that incremental > builds weren't able to notice that a .o needed to be rebuilt to lose the > stale reference.
Not clear where, though, because (at least in my build tree) hw/core/ptimer.d says that hw/core/ptimer.o depends on include/hw/ptimer.h, and tests/Makefile.inc says that tests/ptimer-test depends on hw/core/ptimer.o... thanks -- PMM
