On 29.10.18 18:34, Paolo Bonzini wrote: > Pass other sense, such as UNIT_ATTENTION or BUSY, directly to the > guest. > > Reported-by: Max Reitz <mre...@redhat.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > hw/scsi/scsi-generic.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-)
[...]
> @@ -269,12 +268,15 @@ static void scsi_read_complete(void * opaque, int ret)
> * resulted in sense error but would need emulation.
> * In this case, emulate a valid VPD response.
> */
> - if (s->needs_vpd_bl_emulation) {
> + if (ret == 0 &&
> + (r->io_header.driver_status & SG_ERR_DRIVER_SENSE) &&
> + scsi_parse_sense_buf(r->req.sense, r->io_header.sb_len_wr).key ==
> ILLEGAL_REQUEST &&
As noted by Patchew, this line needs to be split. With that done:
Reviewed-by: Max Reitz <mre...@redhat.com>
Thanks for the series!
Max
signature.asc
Description: OpenPGP digital signature
