Re: [Qemu-devel] [PATCH v3 08/13] hw/gpio/nrf51_gpio: Add nRF51 GPIO peripheral

[Steffen Görtz]

Hi Peter,

> 
> 
>> +static void reflect_dir_bit_in_cnf(NRF51GPIOState *s)
>> +{
>> +    uint32_t value = s->dir;
>> +    for (size_t i = 0; i < NRF51_GPIO_PINS; i++) {
> 
> Similarly here, and I think I saw another use somewhere else
> in this patchset too.

I have removed the c99 style declarations from the gpio device and also from 
the tests in microbit-tests.
Thank you for your review!

Steffen