On Mon, 28 Feb 2011 17:48:34 -0800, "Venkateswararao Jujjuri (JV)" <jv...@linux.vnet.ibm.com> wrote: > On 2/5/2011 10:08 AM, Aneesh Kumar K.V wrote: > > Signed-off-by: Aneesh Kumar K.V <aneesh.ku...@linux.vnet.ibm.com> > > --- > > hw/9pfs/virtio-9p.c | 31 +++++++++++++++++++++++++++++++ > > hw/9pfs/virtio-9p.h | 2 ++ > > 2 files changed, 33 insertions(+), 0 deletions(-) > > > > diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c > > index 2d9ca11..1518e00 100644 > > --- a/hw/9pfs/virtio-9p.c > > +++ b/hw/9pfs/virtio-9p.c > > @@ -1978,6 +1978,36 @@ static void v9fs_fsync(V9fsState *s, V9fsPDU *pdu) > > v9fs_post_do_fsync(s, pdu, err); > > } > > > > +static void v9fs_post_do_syncfs(V9fsState *s, V9fsPDU *pdu, int err) > > +{ > > + if (err == -1) { > > + err = -errno; > > + } > > + complete_pdu(s, pdu, err); > > +} > > + > > +static void v9fs_syncfs(V9fsState *s, V9fsPDU *pdu) > > +{ > > + int err; > > + int32_t fid; > > + size_t offset = 7; > > + V9fsFidState *fidp; > > + > > + pdu_unmarshal(pdu, offset, "d", &fid); > > + fidp = lookup_fid(s, fid); > > + if (fidp == NULL) { > > + err = -ENOENT; > > + v9fs_post_do_syncfs(s, pdu, err); > > + return; > > + } > > + /* > > + * We don't have per file system syncfs > > + * So just return success > > + */ > > + err = 0; > > How about > > err = 0 > if (fidp == NULL) > err = -ENOENT >
That err = 0 will go away once we get the below support in the kernel. http://thread.gmane.org/gmane.linux.file-systems/44628 -aneesh