On 10/25/18 3:45 PM, Emilio G. Cota wrote: > +void HELPER(cpu_halted_set)(CPUArchState *env, uint32_t val) > +{ > + CPUState *cpu = ENV_GET_CPU(env); > + > + cpu->halted = val; > +}
I suppose this is fine as a first step. I'd like to clean up all of the targets to also use a helper like this to also raise EXCP_HALTED. They all perform the same actions, even though this isn't obvious (many of them reuse helpers that also raise target-specific exceptions). That said, Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~