On Wed, Oct 24, 2018 at 10:06:41PM +0100, Peter Maydell wrote: > On 24 October 2018 at 21:54, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Wed, Oct 24, 2018 at 07:21:17AM +0100, Peter Maydell wrote: > >> Hi. This pull request seems to include an accidental update > >> to the dtc submodule. It's in the "intel_iommu: move ce fetching out > >> when sync shadow" commit, and it's not mentioned in the commit > >> message, so I am assuming it is unintentional. > > > Oh not again. At least now you have scripts that catch it, > > I should write a script for that too. Thanks and sorry. > > The relevant part of my scripts is this bit: > https://git.linaro.org/people/peter.maydell/misc-scripts.git/tree/apply-pullreq?id=eeb001fcc1aabd8f077cd2846724120a3aa8f962#n107 > > Specifically, > > if git diff master..staging | grep -q 'Subproject commit'; then > # there's a submodule update in this set of commits > fi > > thanks > -- PMM
Thanks added to my pull request script. -- MST
