On Wed, Oct 24, 2018 at 12:09:18AM +0200, Paolo Bonzini wrote: > On 22/10/2018 20:36, Samuel Ortiz wrote: > > We build a minimal set of ACPI hardware-reduced tables: XSDT, > > FADT, MADT and a DSDT pointed by a RSDP. > > The DSDT only contains one PCI host bridge for now. > > > > This API will be consumed by new x86 machine type but also potentially > > by the ARM virt one. > > > > Cc: "Michael S. Tsirkin" <m...@redhat.com> > > Cc: Igor Mammedov <imamm...@redhat.com> > > Signed-off-by: Samuel Ortiz <sa...@linux.intel.com> > > Do not include patches that essentially add dead code. It is nice to > have hardware-reduced support, but if you want to contribute it you need > to add a user as well, for example the ARM virt machine type. > > In fact, using it in the ARM virt machine type is a no-brainer, so doing > that change (even if it's not yet part of NEMU) would be an excellent > way to reduce your delta, without going through the processing of > convincing QEMU maintainers of the advantages of your new x86 machine type. > > Paolo
Excellent point, thanks Paolo. -- MST
