On 02/27/2011 10:41 AM, Jan Kiszka wrote:
>  +#ifdef CONFIG_IOTHREAD
>  +    /* SIGUSR2 used by posix-aio-compat.c */
>  +    sigemptyset(&set);
>  +    sigaddset(&set, SIGUSR2);
>  +    pthread_sigmask(SIG_UNBLOCK,&set, NULL);

Didn't you want to rename the function for the sake of non-signalfd
blocks like above?

Right.

>  +
>  +    sigemptyset(&set);
>  +    sigaddset(&set, SIGIO);
>  +    sigaddset(&set, SIGALRM);
>  +    sigaddset(&set, SIG_IPI);
>  +    sigaddset(&set, SIGBUS);
>  +    pthread_sigmask(SIG_BLOCK,&set, NULL);
>  +#else
>  +    sigemptyset(&set);

This line is shared and can be moved out of the #ifdef.

It's shared but for different purposes (UNBLOCK for iothread, BLOCK/signalfd for !iothread), so I decided not to hoist it out.

Paolo

Reply via email to