On 19 October 2018 at 17:35, Philippe Mathieu-Daudé <phi...@redhat.com> wrote: > On 19/10/2018 16:46, Peter Maydell wrote: >> Should isa-superio.o also go in its own config flag? > > It could be, but pc87312/smc37c669/vt82c686 inherit of TYPE_ISA_SUPERIO > so would require something like: > > common-obj-$(call land,$(CONFIG_ISA_SUPERIO),$(CONFIG_PC87312)) \ > += pc87312.o > common-obj-$(call land,$(CONFIG_ISA_SUPERIO),$(CONFIG_VT82C686)) \ > += vt82c686.o > common-obj-$(call land,$(CONFIG_ISA_SUPERIO),$(CONFIG_SMC37C669)) \ > += smc37c669-superio.o
This is where it would be nice to be able to say "CONFIG_FOO requires CONFIG_BAR", indeed. thanks -- PMM
