On Sat, Feb 26, 2011 at 5:39 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: > After gathering the comments about the two series I sent separately, > here is the full series for Win32 iothread support, ready to be > applied to uq/master. > > Patches 1 to 5 are generic Win32 improvements, including the qemu-thread > implementation. Because of complex dependencies, I think it's better > if this part is also routed through uq/master. > > Patches 6 to 8 are generic threading improvements, including using > PTHREAD_MUTEX_ERRORCHECK as suggested by Jan. > > Patches 9 to 17 eliminate polling, replacing condition variable > timedwait with wait. > > Patch 18 removes a redundant condition from the TCG cpu_exec_all > function. > > Patches 19 to 21 add all necessary stubs to make iothread compile > with Win32, except the IPI calls. These are provided by patch 22. > > Tested on Wine and Linux, not on "real" Windows. The series introduces > a dependency on Windows 2K or newer. I don't think either 95/98/ME > or Windows NT 3.x are reasonable host systems for QEMU, anyway. > > I incorporated all suggestions from Jan, including his renaming patch > for qemu_*_is_self, and included Aurelien's sh4 tweak to cpu_halted.
All look OK except for a minor structure naming nitpick.