On Oct 16 08:25, Aaron Lindsay wrote: > On Oct 15 13:51, Richard Henderson wrote: > > On 10/10/18 1:37 PM, Aaron Lindsay wrote: > > > --- a/target/arm/machine.c > > > +++ b/target/arm/machine.c > > > @@ -584,7 +584,7 @@ static int cpu_pre_save(void *opaque) > > > { > > > ARMCPU *cpu = opaque; > > > > > > - pmccntr_op_start(&cpu->env); > > > + pmu_op_start(&cpu->env); > > > > Does it make sense to move this patch earlier so that these hooks are > > modified > > once? No big deal if not.
I took another look at this, and I think it makes sense to move the pmccntr_op -> pmu_op changes into "target/arm: Reorganize PMCCNTR accesses", independent of the filtering changes. -Aaron