On 10/16/2018 01:58 PM, Cornelia Huck wrote:
> If ioctl(..., VFIO_DEVICE_RESET) fails, we want to report errno
> instead of ret (which is always -1 on error).
>
> Fixes Coverity issue CID 1396176.
>
> Reported-by: Peter Maydell <peter.mayd...@linaro.org>
> Signed-off-by: Cornelia Huck <coh...@redhat.com>
makes sense
Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com>
> ---
> hw/vfio/ap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
> index 3962bb74e5..65de952f44 100644
> --- a/hw/vfio/ap.c
> +++ b/hw/vfio/ap.c
> @@ -142,7 +142,7 @@ static void vfio_ap_reset(DeviceState *dev)
> ret = ioctl(vapdev->vdev.fd, VFIO_DEVICE_RESET);
> if (ret) {
> error_report("%s: failed to reset %s device: %s", __func__,
> - vapdev->vdev.name, strerror(ret));
> + vapdev->vdev.name, strerror(errno));
> }
> }
>
>
