Gerd Hoffmann <kra...@redhat.com> writes: >> >> + error_propagate(errp, local_err); >> > Shall we use error_propagate(errp, local_err, ("Failed to init VNC >> > server: "); >> > like vnc_display_open does? >> >> I don't know. >> >> The error reporting is somewhat poor around here. Consider: >> >> $ qemu-system-x86_64 -display vnc=:0,share=nope >> qemu-system-x86_64: -display vnc=:0,share=nope: Failed to start VNC >> server: unknown vnc share= option >> >> The "Failed to start VNC server: " prefix doesn't really add value. > > Indeed. > >> Gerd, what do you think? > > I'd keep the messages short.
Okay, I'll delete the prefix. Thanks!