On Mon, 2018-10-15 at 09:59 -0700, Alistair Francis wrote: > On Mon, Oct 15, 2018 at 7:39 AM Andrea Bolognani <abolo...@redhat.com> wrote: > > One more thing that I forgot to bring up earlier: at the same time > > as PCIe support is added, we should also make sure that the > > pcie-root-port device is built into the qemu-system-riscv* binaries > > by default, as that device being missing will cause PCI-enabled > > libvirt guests to fail to start. > > We are dong that aren't we?
Doesn't look that way: $ riscv64-softmmu/qemu-system-riscv64 -device help 2>&1 | head -5 Controller/Bridge/Hub devices: name "pci-bridge", bus PCI, desc "Standard PCI Bridge" name "pci-bridge-seat", bus PCI, desc "Standard PCI Bridge (multiseat)" name "vfio-pci-igd-lpc-bridge", bus PCI, desc "VFIO dummy ISA/LPC bridge for IGD assignment" $ Looking at the output of '-device help' in its entirety, I think there's a lot of stuff in there that doesn't quite belong with a RISC-V guest and that it would probably make sense to compile out. -- Andrea Bolognani / Red Hat / Virtualization