Re: [Qemu-devel] [qemu-s390x] [PATCH v10 2/6] s390x/cpumodel: Set up CPU model for AP device support

[Christian Borntraeger]

On 10/10/2018 10:11 AM, Cornelia Huck wrote:
> On Tue,  9 Oct 2018 13:52:22 -0400
> Tony Krowiak <akrow...@linux.vnet.ibm.com> wrote:
> 
> (...)
> 
>> Signed-off-by: Tony Krowiak <akrow...@linux.ibm.com>
> 
> This patch (and the others) have a mismatch between the author (address
> with vnet), and the s-o-b (address without vnet). While these are
> obviously the same person, the addresses really should match.
> 
> Should I fix up the author to use the vnet-less address?

yes please.

> 
>> Tested-by: Pierre Morel<pmo...@linux.ibm.com>
>> ---
>>  target/s390x/cpu_features.c     | 3 +++
>>  target/s390x/cpu_features_def.h | 3 +++
>>  target/s390x/cpu_models.c       | 2 ++
>>  target/s390x/gen-features.c     | 3 +++
>>  4 files changed, 11 insertions(+)
>