On Thu, Feb 24, 2011 at 01:05:02PM +0100, Paolo Bonzini wrote: > On 02/24/2011 12:54 PM, Aurelien Jarno wrote: > >All targets except SH4 have the same cpu_halted() routine, and it has > >only one caller. It is therefore a good candidate for inlining. > > > >The difference is the handling of the intr_at_halt, which is necessary > >to ignore SR.BL when sleeping. Move intr_at_halt handling out of it, by > >setting this variable while executing the sleep instruction, and > >clearing it when the CPU has been woken-up by an interrupt, whatever the > >state of SR.BL. > > > >Cc: Paolo Bonzini<pbonz...@redhat.com> > >Signed-off-by: Aurelien Jarno<aurel...@aurel32.net> > > Makes sense, thanks! > > You may want to rename intr_at_halt to env->in_sleep or something like that. >
Agreed, I will send a new patch. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurel...@aurel32.net http://www.aurel32.net
