On 02.10.2018 17:22, Eric Blake wrote: > On 10/2/18 6:33 AM, Vladimir Sementsov-Ogievskiy wrote: >> Support modern way of device selecting. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> >> --- >> qapi/block-core.json | 6 ++++-- >> blockdev.c | 8 +++++--- >> 2 files changed, 9 insertions(+), 5 deletions(-) >> >> diff --git a/qapi/block-core.json b/qapi/block-core.json >> index ac3b48ee54..4efd60d8ab 100644 >> --- a/qapi/block-core.json >> +++ b/qapi/block-core.json >> @@ -489,7 +489,9 @@ >> # If only @device parameter is specified, remove all present latency >> histograms >> # for the device. Otherwise, add/reset some of (or all) latency histograms. >> # >> -# @device: device name to set latency histogram for. >> +# @device: device name to set latency histogram for (better use @id). >> +# >> +# @id: The name or QOM path of the guest device. > > As long as we are renaming the command, there's no need to keep a legacy > parameter around. Just get rid of device and replace it by id, rather than > worrying about both. The introduction of the stable command does not have to > carry any baggage left over from the x- preliminary version. >
I'm afraid libvirt is not ready for this. It works either thru drive aliases or qom paths depending on capability that is not turned on yet. It takes some time before capability can be safely turned on (blockjob code is not ready AFAIK). Until that moment we can not use latency API without "device" parameter. Nikolay
