>> # hw/mem/pc-dimm.c >> mhp_pc_dimm_assigned_slot(int slot) "%d" >> -mhp_pc_dimm_assigned_address(uint64_t addr) "0x%"PRIx64 >> +# hw/mem/memory-device.c >> +memory_device_pre_assign_address(uint64_t addr) "0x%"PRIx64 >> +memory_device_assign_address(uint64_t addr) "0x%"PRIx64 >> +memory_device_unassign_address(uint64_t addr) "0x%"PRIx64 > In case we use several memory devices, wouldn't it make sense to pass > the mr name or id as well to uniquely identify the device? > > nit: For debugging purpose it would look simpler to me to use the > original function name for the associated trace (all the more so there > is a single trace within) than the "assign_address" naming. >
Both points make sense. I guess I'll move this patch behind "memory-device: add class function get_device_id()", so I can directly use get_device_id(). Thanks! > Thanks > > Eric >> -- Thanks, David / dhildenb
