On Thu, Sep 27, 2018 at 04:45:56PM +0000, Singh, Brijesh wrote: > To be consistent with intel-iommu: > > - rename the address space to use '_' instead of '-' > - update the memory region relationships > > Signed-off-by: Brijesh Singh <brijesh.si...@amd.com> > Cc: Peter Xu <pet...@redhat.com> > Cc: "Michael S. Tsirkin" <m...@redhat.com> > Cc: Paolo Bonzini <pbonz...@redhat.com> > Cc: Richard Henderson <r...@twiddle.net> > Cc: Eduardo Habkost <ehabk...@redhat.com> > Cc: Marcel Apfelbaum <marcel.apfelb...@gmail.com> > Cc: Tom Lendacky <thomas.lenda...@amd.com> > Cc: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com>
Frankly speaking this is only needed when you want to run AMD IOMMU with VFIO, but I don't see harm too to have it, so: Reviewed-by: Peter Xu <pet...@redhat.com> I really think one day we'll massively merge the Intel/AMD IOMMU code instead of copying things around. But for now I think it's fine. Regards, -- Peter Xu