On 2018-09-17 11:34, David Hildenbrand wrote: > These flags allow us to later on detect if a DATA program interrupt > is to be injected, and which DXC (1,2,3) is to be used. > > Interestingly, some support FP instructions are considered as HFP > instructions (I assume simply because they were available very early). > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > Signed-off-by: David Hildenbrand <da...@redhat.com> > --- > target/s390x/insn-data.def | 254 ++++++++++++++++++------------------- > target/s390x/translate.c | 8 ++ > 2 files changed, 135 insertions(+), 127 deletions(-) [...] > +/* Instruction flags */ > +#define IF_HFP1 0x0001 /* r1 points at fp reg for HFP instructions > */ > +#define IF_HFP2 0x0002 /* r2 points at fp reg for HFP instructions > */ > +#define IF_HFP3 0x0004 /* r3 points at fp reg for HFP instructions > */
I wonder if this would be less confusing if you'd call the constants IF_AFP[123] instead of IF_HFP[123] ? At least that's how DXC1 is called in my version of the PoP (DXC1 = "AFP register", and not "HFP instruction", while DXC2 is called "BFP instruction"). Thomas
