On 27 September 2018 at 06:28, Thomas Huth <th...@redhat.com> wrote: > Speaking of the minimum GCC version that we require: Did we ever > officially define that? Or is it just a result from appendix C in our > qemu-doc? I guess the minimum GCC could be defined to 4.2 since that's > the compiler that was still used in OpenBSD recently, before they > switched to Clang?
It's currently 4.1 because we need the atomics support, and nobody's had a strong reason to require a newer version than that. > Maybe we should add a list in our qemu-doc with some minimum versions > that we require (e.g. also glib), so that it is easier to look this up? Yes. Also for gcc we could put in a "error out if not at least minver" in compiler.h so I don't have to keep looking the minver up by going through the git history :-) > Also when searching for GNUC_PREREQ in the sources, there are at least > some occurances in tests/tcg/arm/fcvt.c and > include/fpu/softfloat-macros.h which we could simplify these days... IIRC I updated all the QEMU_GNUC_PREREQ ones in commit fa54abb8c298f8; I missed the fpu ones because they're using a different macro name, and the fcvt.c is (a) a new file and (b) compiled with a compiler for the guest which isn't necessarily the same as the one we used to build QEMU itself. thanks -- PMM
