Re: [Qemu-devel] [PATCH 1/3] memory: Use MAKE_64BIT_MASK()

[Cédric Le Goater]

Reviewed-by: Cédric Le Goater <c...@kaod.org>

Thanks,

C.

On 9/27/18 2:24 AM, Philippe Mathieu-Daudé wrote:
> Suggested-by: Paolo Bonzini <pbonz...@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
> ---
>  memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/memory.c b/memory.c
> index 9b73892768..385b9d3590 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -582,7 +582,7 @@ static MemTxResult access_with_adjusted_size(hwaddr addr,
>  
>      /* FIXME: support unaligned access? */
>      access_size = MAX(MIN(size, access_size_max), access_size_min);
> -    access_mask = -1ULL >> (64 - access_size * 8);
> +    access_mask = MAKE_64BIT_MASK(0, access_size * 8);
>      if (memory_region_big_endian(mr)) {
>          for (i = 0; i < size; i += access_size) {
>              r |= access_fn(mr, addr + i, value, access_size,
>