On Wed, 26 Sep 2018 12:05:37 +0200 Thomas Huth <th...@redhat.com> wrote:
> On 2018-09-26 11:53, Cornelia Huck wrote: > > It seems our only choice is which kind of ugly we prefer when fixing > > this issue... at least the usage of stw_be_p makes this look a bit > > better :) > > > > But maybe add a comment > > > > /* > > * As the SenseId struct cannot be packed (would cause unaligned > > * accesses), we have to copy the individual fields to an unstructured > > * area using the correct layout. > > */ > > > > so that we don't wonder why it looks like this in the future? > > Sure, could you add it when picking up the patch? Or shall I respin? At that point in time, I'm confused enough to prefer a respin so that I catch everything :)