Yoshiaki Tamura <tamura.yoshi...@lab.ntt.co.jp> wrote: > 2011/2/23 Juan Quintela <quint...@redhat.com>: >> It is only used inside migration.c, and fields on that struct are >> accessed all around the place on that file.
> > I agree to access s->state directly inside of migration.c, but I > disagree to remove get_status() accessor right away. We don't > have strong motivations for doing that AFAIK. Only user outside of migration.c was ui/spice-core.c, and it just wanted to know if migration has finished at all. At this point I was trying to isolate what other parts of MigrationState are used externally. That way, it gets easier to change that later. At this point, only things used outside of migration.c are: - write, clase, get_error: trivial to fix, just add setters for them. - fd: that is not enterely trivial to fix. Later, Juan.
