On 9/12/18 11:01 AM, Li Qiang wrote:
From: Li Qiang <liq...@gmail.com>

Signed-off-by: Li Qiang <liq...@gmail.com>

This commit message doesn't state why. The cover letter does, but that doesn't get checked into git. A year from now, if someone lands on this commit during a bisect, it would help if the commit message told them why you are adding a no-op callback here, instead of trying to fix the caller to treat a NULL callback as acceptable.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Reply via email to