On Mon, 2018-09-10 at 14:38 -0300, Eduardo Habkost wrote: > On Thu, Sep 06, 2018 at 06:00:29AM +0000, Hu, Robert wrote: > > > > > > > > Yeah, since this type is used in the qom-get backdoor that evades > > > introspection, > > > it's even more important that you follow the backwards- > > > compatibility rules and > > > not rename or delete any previously-mandatory members, since > > > libvirt CAN'T > > > introspect if such changes have happened. > > > > > > > [Robert Hoo] > > Oh, this is more complicated than my thought. > > So, Eduardo, how about leave the QAPI expansion for MSR based > > features to other > > professional people? > > I think it's now clear that we can't add MSR features to > "feature-words" in a compatible way, so any mechanism to > introspect MSR features will need a separate property or QMP > command. > > I also think "feature-words" needs to be replaced with something > better. Probably libvirt should be able to grab all information > it needs by looking at the boolean QOM properties instead of the > low-level info at "feature-words". > > This means I agree to leave this functionality out of the MSR > feature patch series for now.
Thanks Eduardo. Clear to me now. >
