On 2018-08-24 00:08, John Snow wrote: > Change the manual deferment to mirror_exit into the implicit > callback to job_exit and the mirror_exit callback. > > This does change the order of some bdrv_unref calls and job_completed, > but thanks to the new context in which we call .exit, this is safe to > defer the possible flushing of any nodes to the job_finalize_single > cleanup stage. > > Signed-off-by: John Snow <js...@redhat.com> > --- > block/mirror.c | 25 +++++++++---------------- > 1 file changed, 9 insertions(+), 16 deletions(-)
Looks good, but the comment about why @src is bdrv_ref()'ed needs to be updated. Max
signature.asc
Description: OpenPGP digital signature
