On 23 August 2018 at 18:45, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 23 August 2018 at 18:42, Richard Henderson > <richard.hender...@linaro.org> wrote: >> On 08/20/2018 07:11 AM, Peter Maydell wrote: >>> + mmc->scc_id = 0x41040000 | (0x505 << 4); >> >> Is it any less clear to say 0x41045050? > > It makes it a bit clearer that that field is the number > from the image name, I think. (Compare the an385 > and an511 init functions, which I notice I also need > to update to fix the equivalent bug there.)
...though I guess that's less true now we're using a hex constant rather than decimal. So yeah, we could just say 0x41045050. thanks -- PMM
