Add a new command, returning block nodes (and their users) graph. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> --- qapi/block-core.json | 91 +++++++++++++++++++++++ include/block/block.h | 1 + include/sysemu/block-backend.h | 2 + block.c | 129 +++++++++++++++++++++++++++++++++ block/block-backend.c | 5 ++ blockdev.c | 5 ++ 6 files changed, 233 insertions(+)
diff --git a/qapi/block-core.json b/qapi/block-core.json index 4c7a37afdc..34cdc595d7 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1629,6 +1629,97 @@ ## { 'command': 'query-named-block-nodes', 'returns': [ 'BlockDeviceInfo' ] } +## +# @BlockGraphNodeType: +# +# Since: 3.1 +## +{ 'enum': 'BlockGraphNodeType', + 'data': [ 'blk', 'job', 'bds' ] } + +## +# @BlockGraphNode: +# +# Since: 3.1 +## +{ 'struct': 'BlockGraphNode', + 'data': { 'id': 'uint64', 'type': 'BlockGraphNodeType', 'name': 'str' } } + +## +# @BlockPermission: +# +# Enum of base block permissions. +# +# @consistent-read: A user that has the "permission" of consistent reads is +# guaranteed that their view of the contents of the block +# device is complete and self-consistent, representing the +# contents of a disk at a specific point. +# For most block devices (including their backing files) this +# is true, but the property cannot be maintained in a few +# situations like for intermediate nodes of a commit block +# job. +# +# @write: This permission is required to change the visible disk contents. +# +# @write-unchanged: This permission (which is weaker than BLK_PERM_WRITE) is +# both enough and required for writes to the block node when +# the caller promises that the visible disk content doesn't +# change. +# As the BLK_PERM_WRITE permission is strictly stronger, +# either is sufficient to perform an unchanging write. +# +# @resize: This permission is required to change the size of a block node. +# +# @graph-mod: This permission is required to change the node that this +# BdrvChild points to. +# +# Since: 3.1 +## + { 'enum': 'BlockPermission', + 'data': [ 'consistent-read', 'write', 'write-unchanged', 'resize', + 'graph-mod' ] } +## +# @BlockGraphEdge: +# +# Block Graph edge description for x-debug-query-block-graph. +# +# @parent: parent id +# +# @child: child id +# +# @name: name of the relation (examples are 'file' and 'backing') +# +# @perm: granted permissions for the parent operating on the child +# +# @shared-perm: permissions that can still be granted to other users of the +# child while it is still attached this parent +# +# Since: 3.1 +## +{ 'struct': 'BlockGraphEdge', + 'data': { 'parent': 'uint64', 'child': 'uint64', + 'name': 'str', 'perm': [ 'BlockPermission' ], + 'shared-perm': [ 'BlockPermission' ] } } + +## +# @BlockGraph: +# +# Block Graph - list of nodes and list of edges. +# +# Since: 3.1 +## +{ 'struct': 'BlockGraph', + 'data': { 'nodes': ['BlockGraphNode'], 'edges': ['BlockGraphEdge'] } } + +## +# @x-debug-query-block-graph: +# +# Get the block graph. +# +# Since: 3.1 +## +{ 'command': 'x-debug-query-block-graph', 'returns': 'BlockGraph' } + ## # @drive-mirror: # diff --git a/include/block/block.h b/include/block/block.h index 4e0871aaf9..6f2ccad040 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -448,6 +448,7 @@ void bdrv_eject(BlockDriverState *bs, bool eject_flag); const char *bdrv_get_format_name(BlockDriverState *bs); BlockDriverState *bdrv_find_node(const char *node_name); BlockDeviceInfoList *bdrv_named_nodes_list(Error **errp); +BlockGraph *bdrv_get_block_graph(Error **errp); BlockDriverState *bdrv_lookup_bs(const char *device, const char *node_name, Error **errp); diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h index 830d873f24..32ca5c1b12 100644 --- a/include/sysemu/block-backend.h +++ b/include/sysemu/block-backend.h @@ -237,4 +237,6 @@ int coroutine_fn blk_co_copy_range(BlockBackend *blk_in, int64_t off_in, int bytes, BdrvRequestFlags read_flags, BdrvRequestFlags write_flags); +const BdrvChild *blk_root(BlockBackend *blk); + #endif diff --git a/block.c b/block.c index 6161dbe3eb..588f5a2648 100644 --- a/block.c +++ b/block.c @@ -4003,6 +4003,135 @@ BlockDeviceInfoList *bdrv_named_nodes_list(Error **errp) return list; } +#define QAPI_LIST_ADD(list, element) do { \ + typeof(list) _tmp = g_new(typeof(*(list)), 1); \ + _tmp->value = (element); \ + _tmp->next = (list); \ + list = _tmp; \ +} while (0) + +typedef struct BlockGraphConstructor { + BlockGraph *graph; + GHashTable *hash; +} BlockGraphConstructor; + +static BlockGraphConstructor *graph_new(void) +{ + BlockGraphConstructor *gr = g_new(BlockGraphConstructor, 1); + + gr->graph = g_new0(BlockGraph, 1); + gr->hash = g_hash_table_new(NULL, NULL); + + return gr; +} + +static BlockGraph *graph_finalize(BlockGraphConstructor *gr) +{ + g_hash_table_destroy(gr->hash); + + return gr->graph; +} + +static uint64_t graph_node_num(BlockGraphConstructor *gr, void *node) +{ + uint64_t ret = (uint64_t)g_hash_table_lookup(gr->hash, node); + + if (ret > 0) { + return ret; + } + + ret = g_hash_table_size(gr->hash) + 1; + g_hash_table_insert(gr->hash, node, (void *)ret); + + return ret; +} + +static void graph_add_node(BlockGraphConstructor *gr, void *node, + BlockGraphNodeType type, const char *name) +{ + BlockGraphNode *n; + + n = g_new0(BlockGraphNode, 1); + + n->id = graph_node_num(gr, node); + n->type = type; + n->name = g_strdup(name); + + QAPI_LIST_ADD(gr->graph->nodes, n); +} + +static void graph_add_edge(BlockGraphConstructor *gr, void *parent, + const BdrvChild *child) +{ + typedef struct { + unsigned int flag; + BlockPermission num; + } PermissionMap; + + static PermissionMap permissions[] = { + { BLK_PERM_CONSISTENT_READ, BLOCK_PERMISSION_CONSISTENT_READ }, + { BLK_PERM_WRITE, BLOCK_PERMISSION_WRITE }, + { BLK_PERM_WRITE_UNCHANGED, BLOCK_PERMISSION_WRITE_UNCHANGED }, + { BLK_PERM_RESIZE, BLOCK_PERMISSION_RESIZE }, + { BLK_PERM_GRAPH_MOD, BLOCK_PERMISSION_GRAPH_MOD }, + { 0, 0 } + }; + PermissionMap *p; + BlockGraphEdge *edge; + + edge = g_new0(BlockGraphEdge, 1); + + edge->parent = graph_node_num(gr, parent); + edge->child = graph_node_num(gr, child->bs); + edge->name = g_strdup(child->name); + + for (p = permissions; p->flag; p++) { + if (p->flag & child->perm) { + QAPI_LIST_ADD(edge->perm, p->num); + } + if (p->flag & child->shared_perm) { + QAPI_LIST_ADD(edge->shared_perm, p->num); + } + } + + QAPI_LIST_ADD(gr->graph->edges, edge); +} + + +BlockGraph *bdrv_get_block_graph(Error **errp) +{ + BlockBackend *blk; + BlockJob *job; + BlockDriverState *bs; + BdrvChild *child; + BlockGraphConstructor *gr = graph_new(); + + for (blk = blk_all_next(NULL); blk; blk = blk_all_next(blk)) { + graph_add_node(gr, blk, BLOCK_GRAPH_NODE_TYPE_BLK, blk_name(blk)); + if (blk_root(blk)) { + graph_add_edge(gr, blk, blk_root(blk)); + } + } + + for (job = block_job_next(NULL); job; job = block_job_next(job)) { + GSList *el; + + graph_add_node(gr, job, BLOCK_GRAPH_NODE_TYPE_JOB, job->job.id); + for (el = job->nodes; el; el = el->next) { + graph_add_edge(gr, job, (BdrvChild *)el->data); + } + } + + QTAILQ_FOREACH(bs, &graph_bdrv_states, node_list) { + graph_add_node(gr, bs, BLOCK_GRAPH_NODE_TYPE_BDS, bs->node_name); + QLIST_FOREACH(child, &bs->children, next) { + graph_add_edge(gr, bs, child); + } + } + + return graph_finalize(gr); +} + BlockDriverState *bdrv_lookup_bs(const char *device, const char *node_name, Error **errp) diff --git a/block/block-backend.c b/block/block-backend.c index fa120630be..f3704fe87d 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -2234,3 +2234,8 @@ int coroutine_fn blk_co_copy_range(BlockBackend *blk_in, int64_t off_in, blk_out->root, off_out, bytes, read_flags, write_flags); } + +const BdrvChild *blk_root(BlockBackend *blk) +{ + return blk->root; +} diff --git a/blockdev.c b/blockdev.c index 72f5347df5..3b98ce7571 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3485,6 +3485,11 @@ BlockDeviceInfoList *qmp_query_named_block_nodes(Error **errp) return bdrv_named_nodes_list(errp); } +BlockGraph *qmp_x_debug_query_block_graph(Error **errp) +{ + return bdrv_get_block_graph(errp); +} + BlockJob *do_blockdev_backup(BlockdevBackup *backup, JobTxn *txn, Error **errp) { -- 2.18.0