On 18.08.2018 04:56, Philippe Mathieu-Daudé wrote: > Fedora 29 comes with GCC 8.1 which added the 'stringop-truncation' checks. > > Replace the strncpy() calls by g_strlcpy() to avoid the following warning: > > migration/global_state.c: In function 'global_state_store_running': > migration/global_state.c:45:5: error: 'strncpy' specified bound 100 equals > destination size [-Werror=stringop-truncation] > strncpy((char *)global_state.runstate, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > state, sizeof(global_state.runstate)); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Reported-by: Howard Spoelstra <hsp.c...@gmail.com> > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > See http://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg03723.html > > migration/global_state.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/global_state.c b/migration/global_state.c > index 8e8ab5c51e..d5df502cd5 100644 > --- a/migration/global_state.c > +++ b/migration/global_state.c > @@ -42,7 +42,7 @@ int global_state_store(void) > void global_state_store_running(void) > { > const char *state = RunState_str(RUN_STATE_RUNNING); > - strncpy((char *)global_state.runstate, > + g_strlcpy((char *)global_state.runstate, > state, sizeof(global_state.runstate)); > } > >
Reviewed-by: David Hildenbrand <da...@redhat.com> -- Thanks, David / dhildenb
