On Sat, Aug 18, 2018 at 14:45:54 +0800, Fam Zheng wrote: > On Fri, 08/17 19:14, no-re...@patchew.org wrote: (snip) > > /tmp/qemu-test/src/include/qemu/thread.h:101:1: error: all paths through > > this function will call itself [-Werror,-Winfinite-recursion] (snip) > > subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', > > '--label', 'com.qemu.instance.uuid=3dee4156a28c11e8b93c52540069c830', '-u', > > '1000', '--security-opt', 'seccomp=unconfined', '--rm', '--net=none', '-e', > > 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=8', > > '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', > > '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', > > '/var/tmp/patchew-tester-tmp-pdpmalc5/src/docker-src.2018-08-17-22.12.51.31192:/var/tmp/qemu:z,ro', > > 'qemu:ubuntu', '/var/tmp/qemu/run', 'test-clang']' returned non-zero exit > > status 2 > > make[1]: *** [tests/docker/Makefile.include:216: docker-run] Error 1 > > make[1]: Leaving directory '/var/tmp/patchew-tester-tmp-pdpmalc5/src' > > make: *** [tests/docker/Makefile.include:250: docker-run-test-clang@ubuntu] > > Error 2 > > > > real 1m55.855s > > user 0m4.734s > > sys 0m3.377s > > === OUTPUT END === > > > > Test command exited with code: 2 > > Could you check if this one is relevant?
It is! Somehow gcc didn't catch this. I've pushed a v4 with the appended fix in it: https://github.com/cota/qemu/tree/sync-profiler-v4 Thanks, Emilio --- diff --git a/include/qemu/thread.h b/include/qemu/thread.h index b41c0ae16a..dacebcfff0 100644 --- a/include/qemu/thread.h +++ b/include/qemu/thread.h @@ -63,7 +63,7 @@ extern QemuCondWaitFunc qemu_cond_wait_func; _f(m, __FILE__, __LINE__); \ }) -#define qemu_rec_trymutex_lock(m) ({ \ +#define qemu_rec_mutex_trylock(m) ({ \ QemuRecMutexTrylockFunc _f; \ _f = atomic_read(&qemu_rec_mutex_trylock_func); \ _f(m, __FILE__, __LINE__); \
